feat(node): Add socketIoIntegration to node
#13578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnusburton
approved these changes
Sep 5, 2024
|
Tests to be added. WIP |
Zen-cronic
commented
Sep 14, 2024
|
|
||
| createRunner(__dirname, 'scenario.js') | ||
| .expect({ transaction: SERVER_TRANSACTION }) | ||
| .expect({ transaction: CLIENT_TRANSACTION }) |
There was a problem hiding this comment.
I'm not sure why the server socket and client socket are not part of the same transaction. In scenario.js, the server socket emits an event to the client, which triggers the client to send back to the server.
Update: the transactions are also not part of the same trace (different trace_id) - verified by debugging.
Zen-cronic
force-pushed
the
feat/socketioIntegration-node
branch
from
93e0e53
to
8d2e189
Compare
Add otel integration and e2e tests. Signed-off-by: Kaung Zin Hein <[email protected]>
Signed-off-by: Kaung Zin Hein <[email protected]>
Signed-off-by: Kaung Zin Hein <[email protected]>
Zen-cronic
commented
Sep 15, 2024
| onHook(span) { | ||
| addOriginToSpan(span, 'auto.socket.otel.consumer'); | ||
| }, | ||
| traceReserved: true, |
There was a problem hiding this comment.
We should expose options such as traceReserved, emitIgnoreEventList, and onIgnoreEventList for users to configure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13310
yarn lint) & (yarn test).